dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.2 KiB
1.2 KiB
issue, title, severity, domain, status, resolved, fix, labels, status, created, source
| issue | title | severity | domain | status | resolved | fix | labels | status | created | source | |||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 024 | GET /api/payment/stats has no admin role guard — any authenticated user can read aggregate payment stats | major | Payment | resolved | 2026-05-29 | Already guarded by authenticateToken + authorizeRoles('admin') at paymentRoutes.ts line 56. Confirmed in current code. |
|
open | 2026-05-29 | Doc vs Code Audit 2026-05-29 |
🟠 GET /api/payment/stats has no admin role guard — any authenticated user can read aggregate payment stats
Severity: major Domain: Payment Labels: security, bug, backend, major, privilege-escalation
Description
GET /api/payment/stats (controller-pattern route) requires only authenticateToken. The /api/payment/payments/stats route requires admin role. Frontend uses the non-admin-gated path.
Current Behavior
Any authenticated buyer can read aggregate payment platform statistics.
Expected Behavior
Stats endpoint should be admin-only or return only caller-scoped data for non-admins.
Affected Files
backend/src/routes/paymentRoutes.ts