dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.1 KiB
1.1 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | |||
|---|---|---|---|---|---|---|---|---|---|---|
| 108 | Scanner: unauthenticated startup when SCANNER_API_KEY unset | medium | Scanner |
|
open | 2026-05-30 | Full Codebase Audit 2026-05-30 |
Scanner: unauthenticated startup when SCANNER_API_KEY unset
Severity: medium Domain: Scanner Labels: security, scanner, configuration
Description
scanner/config.go:111 logs a warning when SCANNER_API_KEY is empty but allows the server to start and accept unauthenticated requests. An operator mistake or CI misconfiguration can deploy a scanner that accepts any intent without an API key.
Options
- Fail fast in non-dev when
SCANNER_API_KEYis empty. - Allow empty key only when bound to localhost; refuse otherwise.
- Keep warning but add a required-in-prod env flag.
Recommendation
Refuse to start (or restrict to loopback) when no API key is set outside local dev.
Affected Files
scanner/config.go:111
References
- Full Codebase Audit 2026-05-30 — DEC-60