dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.5 KiB
1.5 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | ||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| 064 | Backend: REQUEST_NETWORK_ALLOW_TEST_WEBHOOKS bypasses signature verification | high | Payment |
|
open | 2026-05-30 | Full Codebase Audit 2026-05-30 |
Backend: REQUEST_NETWORK_ALLOW_TEST_WEBHOOKS bypasses signature verification
Severity: high Domain: Payment Labels: security, backend, webhook, test-bypass
Description
REQUEST_NETWORK_ALLOW_TEST_WEBHOOKS env flag disables HMAC signature verification on Request Network webhooks at requestNetworkRoutes.ts:104 and requestNetworkAdapter.ts:77. If this flag is set in production (or if NODE_ENV is not production), any unauthenticated actor can forge a webhook and trigger payment completion.
Options
- Gate the bypass on
NODE_ENV === 'test'only and ignore the env flag in production. - Require both
NODE_ENV !== 'production'AND the flag. - Remove the env-flag bypass entirely; use a dedicated test harness.
Recommendation
Allow the bypass only when NODE_ENV === 'test'; ignore REQUEST_NETWORK_ALLOW_TEST_WEBHOOKS in production. Apply the same fix in requestNetworkAdapter.ts:77.
Affected Files
backend/src/services/payment/requestNetwork/requestNetworkRoutes.ts:104backend/src/services/payment/requestNetwork/requestNetworkAdapter.ts:77
References
- Full Codebase Audit 2026-05-30 — DEC-25