dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.2 KiB
1.2 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | |||
|---|---|---|---|---|---|---|---|---|---|---|
| 097 | Backend: validTransitions map missing 'in_negotiation' key | medium | Marketplace |
|
open | 2026-05-30 | Full Codebase Audit 2026-05-30 |
Backend: validTransitions map missing 'in_negotiation' key
Severity: medium Domain: Marketplace Labels: bug, backend, state-machine
Description
marketplaceController.ts:544-555 defines a validTransitions map for PurchaseRequest status transitions but has no entry for 'in_negotiation'. A PurchaseRequest in the in_negotiation state cannot transition to any other state via this validator.
Options
- Add
'in_negotiation'with its allowed next statuses (e.g.payment,cancelled). - Treat missing key as 'allow same-tier transitions' default.
- Derive transitions from
STATUS_PROGRESSION_ORDERinstead of a hand-maintained map.
Recommendation
Add an explicit 'in_negotiation' entry with the correct next statuses. Requires product/state-machine confirmation of valid transitions.
Affected Files
backend/src/services/marketplace/marketplaceController.ts:544-555
References
- Full Codebase Audit 2026-05-30 — DEC-35