dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.3 KiB
1.3 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | |||
|---|---|---|---|---|---|---|---|---|---|---|
| 105 | Backend: no startup validation of required env vars — silent misconfiguration | medium | Configuration |
|
open | 2026-05-30 | Full Codebase Audit 2026-05-30 |
Backend: no startup validation of required env vars — silent misconfiguration
Severity: medium Domain: Configuration Labels: backend, reliability, configuration
Description
backend/src/shared/config/index.ts:32 reads env vars without validating they are present or have correct types. A misconfigured deployment (missing JWT_SECRET, MONGODB_URI, or SMTP_PORT) starts silently and fails only at runtime when those vars are first used, making misconfiguration hard to diagnose.
Options
- Validate required vars with a schema (zod/envalid) and exit on missing/NaN.
- Manual assertions for the critical few (
PORT,JWT_SECRET,MONGODB_URI,SMTP_PORT). - Log-and-continue warnings only.
Recommendation
Add schema-based validation that fails fast on missing/invalid required vars. Changes startup behavior.
Affected Files
backend/src/shared/config/index.ts:32
References
- Full Codebase Audit 2026-05-30 — DEC-54