dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.4 KiB
1.4 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | |||
|---|---|---|---|---|---|---|---|---|---|---|
| 099 | Backend: on-demand RN reconciliation in getPaymentById can race — double-processing risk | medium | Payment |
|
open | 2026-05-30 | Full Codebase Audit 2026-05-30 |
Backend: on-demand RN reconciliation in getPaymentById can race — double-processing risk
Severity: medium Domain: Payment Labels: bug, backend, concurrency
Description
paymentController.ts:407-466 triggers RN reconciliation on every GET /payment/:id call. If two browser tabs or requests call this concurrently on a pending payment, both can read status:'pending' and both trigger the completion side-effects before either write commits.
Options
- Use an atomic
findOneAndUpdateguarded onstatus:'pending'so only one writer wins. - Add a distributed lock (Redis) around reconciliation per payment.
- Move reconciliation off the read path into a single-writer background job.
Recommendation
Make the status transition atomic (findOneAndUpdate filtering on current status) so only the first concurrent caller advances it; ideally move reconciliation off the GET path.
Affected Files
backend/src/services/payment/paymentController.ts:407-466
References
- Full Codebase Audit 2026-05-30 — DEC-37