dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.3 KiB
1.3 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | |||
|---|---|---|---|---|---|---|---|---|---|---|
| 092 | Backend: JWT refresh and access tokens share the same secret; middleware skips token type check | medium | Authentication |
|
open | 2026-05-30 | Full Codebase Audit 2026-05-30 |
Backend: JWT refresh and access tokens share the same secret; middleware skips token type check
Severity: medium Domain: Authentication Labels: security, backend, jwt
Description
src/services/auth/authService.ts:44 signs both access and refresh tokens with the same secret. authenticateToken middleware does not check token.type, so a refresh token can be presented as an access token and accepted by protected routes.
Options
- Add a
type:'access'claim check inauthenticateTokenmiddleware (rejecttype:'refresh'). - Use separate secrets for access vs refresh tokens.
- Add audience/issuer claims and verify them in middleware.
Recommendation
Enforce a token-type check in the middleware (reject refresh tokens) and ideally split secrets. Both changes touch core auth verification.
Affected Files
backend/src/services/auth/authService.ts:44backend/src/middleware/authenticateToken.ts(or equivalent)
References
- Full Codebase Audit 2026-05-30 — DEC-26