dceaf82934
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1.2 KiB
1.2 KiB
issue, title, severity, domain, labels, status, created, source
| issue | title | severity | domain | labels | status | created | source | |||
|---|---|---|---|---|---|---|---|---|---|---|
| 071 | Backend: getReferrals N+1 — PurchaseRequest + PointTransaction per referral | high | Points |
|
open | 2026-05-30 | Full Codebase Audit 2026-05-30 |
Backend: getReferrals N+1 — PurchaseRequest + PointTransaction per referral
Severity: high Domain: Points Labels: performance, backend, n-plus-1
Description
PointsService.ts:312 issues two sequential DB queries per referred user: one PurchaseRequest.findOne and one PointTransaction.find. With N referrals, this results in 2×N queries. Under load this will cause slow responses and high DB load.
Options
- Batch with
$inqueries and aggregate grouped by referred user. - Precompute referral stats in a maintained summary doc.
- Add pagination plus batched lookups.
Recommendation
Replace per-referral queries with batched $in queries and an aggregation grouped by user; add pagination.
Affected Files
backend/src/services/points/PointsService.ts:312
References
- Full Codebase Audit 2026-05-30 — DEC-41