audit: 2026-05-30 full-codebase audit — report, issues, docs, runbooks
Full-codebase-audit 2026-05-30 outputs: - Audit report: 09 - Audits/Full Codebase Audit - 2026-05-30.md - 81 issue files ISSUE-055..135 (decisions + 1 skipped no-brainer). - Scanner docs from scratch (was zero): architecture, data model, API ref, payment flow, operations runbook + repo README. - Doc-sync updates across API reference, data models, flows, design system. - Secret Rotation Runbook (08 - Operations) for the exposed credentials. - Reusable workflow guide (07 - Development) + .claude/workflows/full-codebase-audit.js. Issues remain status:open intentionally — the code fixes are uncommitted-then-committed working-tree changes per repo and aren't "resolved" until merged/deployed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,38 @@
|
||||
---
|
||||
issue: 087
|
||||
title: "Frontend: getPaymentStatus and checkPaymentStatus hit different endpoints"
|
||||
severity: medium
|
||||
domain: Payment
|
||||
labels: [bug, frontend]
|
||||
status: open
|
||||
created: 2026-05-30
|
||||
source: Full Codebase Audit 2026-05-30
|
||||
---
|
||||
|
||||
# Frontend: getPaymentStatus and checkPaymentStatus hit different endpoints
|
||||
|
||||
**Severity:** medium
|
||||
**Domain:** Payment
|
||||
**Labels:** bug, frontend
|
||||
|
||||
## Description
|
||||
|
||||
`src/actions/payment.ts:62` has two functions — `getPaymentStatus` and `checkPaymentStatus` — that appear to serve the same purpose but call different endpoints (`/payment/:id/status` vs `/payment/payments/:id/status`). Only one of these can be the correct backend path.
|
||||
|
||||
## Options
|
||||
|
||||
1. Point `getPaymentStatus` at the registry-defined `/payment/:id/status` and deduplicate with `checkPaymentStatus`.
|
||||
2. Add `/payment/payments/:id/status` to the endpoints registry if backend truly serves it.
|
||||
3. Remove the redundant `getPaymentStatus` and migrate callers to `checkPaymentStatus`.
|
||||
|
||||
## Recommendation
|
||||
|
||||
Verify the real backend route, then collapse to a single function using the registry path. Could break callers, so verify before removing.
|
||||
|
||||
## Affected Files
|
||||
|
||||
- `frontend/src/actions/payment.ts:62`
|
||||
|
||||
## References
|
||||
|
||||
- [Full Codebase Audit 2026-05-30](../09%20-%20Audits/Full%20Codebase%20Audit%20-%202026-05-30.md) — DEC-16
|
||||
Reference in New Issue
Block a user