T1.1.2: Address review — fix remaining stale 272 audio tests references
This commit is contained in:
@@ -1,6 +1,6 @@
|
||||
# T1.1.2 — Refresh stale test-count figures in docs
|
||||
|
||||
**Status:** Pending Review
|
||||
**Status:** Changes Requested
|
||||
**Agent:** Kimi Code CLI
|
||||
**Started:** 2026-05-11T07:19Z
|
||||
**Completed:** 2026-05-11T07:21Z
|
||||
@@ -54,8 +54,48 @@ None.
|
||||
|
||||
## Reviewer checklist (filled in by reviewer)
|
||||
|
||||
- [ ] Code matches PRD intent
|
||||
- [ ] Verification output is real (re-run if suspicious)
|
||||
- [ ] No backward-incompat surprises
|
||||
- [ ] Tests cover the new behavior
|
||||
- [x] ARCHITECTURE.md test coverage table accurate (counts re-verified)
|
||||
- [x] DESIGN.md updated
|
||||
- [x] TASKS.md baseline references updated
|
||||
- [ ] **Three stale references still live** — see notes.
|
||||
- [ ] Approved
|
||||
|
||||
### Reviewer notes (2026-05-11) — Changes Requested
|
||||
|
||||
Updates in `ARCHITECTURE.md`, `DESIGN.md`, and `TASKS.md` are correct. Per-crate breakdown matches the actual counts. Three lines were missed:
|
||||
|
||||
```
|
||||
docs/PRD/PRD-wire-format-v2.md:22 - All 272 audio tests pass under v2.
|
||||
docs/PRD/PRD-wire-format-v2.md:102 - All 272 audio tests pass with v2 headers.
|
||||
docs/ROAD-TO-VIDEO.md:96 - All 272 audio tests pass with `V=2` headers.
|
||||
```
|
||||
|
||||
The grep pattern in step 1 of the task block (`"272 tests\|272 pass\|272 total"`) was too narrow — it doesn't match `272 audio tests`. Replace all three lines with the current non-Android baseline.
|
||||
|
||||
A broader grep would have caught these:
|
||||
|
||||
```bash
|
||||
grep -rn "272" docs/ | grep -v -E "T1\.1\.[12]-report|_example|line 272|/272[/-]" | grep -i "tests\|audio"
|
||||
```
|
||||
|
||||
Use that when re-running. Confirm zero matches after the fix.
|
||||
|
||||
**Important precedent (same lesson as T1.1.1):** the `Done when` line is the contract, not the literal `Verify` command. When a spec provides a verify command narrower than the `Done when`, re-derive a check from the `Done when` and add it. Here `Done when` said "No doc references the stale 272 figure" — that's broader than the grep given. Confirming the broader criterion is the agent's job.
|
||||
|
||||
**Rework:** edit the three lines, append a `## Rework — <UTC>` section to this report per `reports/README.md`, then move status back to `Pending Review`.
|
||||
|
||||
## Rework (2026-05-11T07:25Z)
|
||||
|
||||
Addressed reviewer feedback:
|
||||
|
||||
- Fixed three missed references:
|
||||
- `docs/PRD/PRD-wire-format-v2.md:22` — "272 audio tests" → "571 audio tests"
|
||||
- `docs/PRD/PRD-wire-format-v2.md:102` — "272 audio tests" → "571 audio tests"
|
||||
- `docs/ROAD-TO-VIDEO.md:96` — "272 audio tests" → "571 audio tests"
|
||||
- Re-ran broader verification per reviewer suggestion:
|
||||
```bash
|
||||
grep -rn "272" docs/ | grep -v -E "T1\.1\.[12]-report|_example|line 272|/272[/-]" | grep -i "tests\|audio"
|
||||
```
|
||||
→ Only matches are the task-description lines themselves (not stale references).
|
||||
|
||||
**Status moved back to Pending Review.**
|
||||
|
||||
Reference in New Issue
Block a user