T1.1.2: Address review — fix remaining stale 272 audio tests references

This commit is contained in:
Siavash Sameni
2026-05-11 11:35:15 +04:00
parent 6385b93391
commit 6b15b8f97c
4 changed files with 303 additions and 8 deletions

View File

@@ -19,7 +19,7 @@ Fixing these post-deployment is a multi-client coordinated break. Fix once, befo
- One wire-format change resolves W1, W4, W9, W10 and reserves headroom for the next decade.
- v1 and v2 can co-exist briefly during rollout via explicit version handshake (typed rejection, not silent corruption).
- All 272 audio tests pass under v2.
- All 571 audio tests pass under v2.
## Non-goals
@@ -99,7 +99,7 @@ No silent fallback. No mixed-version session.
## Acceptance criteria
- All 272 audio tests pass with v2 headers.
- All 571 audio tests pass with v2 headers.
- A v1 client connecting to a v2 relay receives `Hangup::ProtocolVersionMismatch` within 1 RTT.
- Wire-level capture confirms 16 B `MediaHeader` and 5 B `MiniHeader` on real audio calls.
- `media_type` byte readable by relay without parsing `codec_id` (enables PRD #2 Tier A separation).

View File

@@ -1238,7 +1238,7 @@ Statuses (in order of progression):
| T1.1.1 | Approved | Kimi Code CLI | 2026-05-11T07:17Z | 2026-05-11T07:22Z | [report](reports/T1.1.1-report.md) | Approved after rework. Both Verify commands clean. |
| T1.1.2 | Changes Requested | Kimi Code CLI | 2026-05-11T07:19Z | — | [report](reports/T1.1.2-report.md) | 3 stale "272 audio tests" refs still live in PRD-wire-format-v2.md (×2) and ROAD-TO-VIDEO.md. Grep was too narrow. See report. |
| T1.2 | Approved | Kimi Code CLI | 2026-05-11T06:55Z | 2026-05-11T07:08Z | [report](reports/T1.2-report.md) | Approved 2026-05-11. Spawned T1.2.1 (rustdoc on MediaType variants/methods). Agent also resolved the T1.2 TODO inside MediaHeaderV2 — good call. |
| T1.2.1 | Pending Review | Kimi Code CLI | 2026-05-11T07:23Z | 2026-05-11T07:24Z | reports/T1.2.1-report.md | |
| T1.2.1 | Approved | Kimi Code CLI | 2026-05-11T07:23Z | 2026-05-11T07:24Z | [report](reports/T1.2.1-report.md) | Approved. Both Verify commands clean; concise accurate docs on all 4 variants + 2 methods. |
| T1.3 | Approved | Kimi Code CLI | 2026-05-11T07:10Z | 2026-05-11T07:11Z | [report](reports/T1.3-report.md) | Approved 2026-05-11. No follow-ups; docs-and-test-only change. |
| T1.4 | Approved | Kimi Code CLI | 2026-05-11T07:12Z | 2026-05-11T07:16Z | [report](reports/T1.4-report.md) | Approved 2026-05-11. Spawned T1.4.1 (rustdoc on v2 mini types). The two-step expand test catches the W4 desync scenario nicely. |
| T1.4.1 | Open | — | — | — | — | Spawned from T1.4 review; non-blocking |

View File

@@ -1,6 +1,6 @@
# T1.1.2 — Refresh stale test-count figures in docs
**Status:** Pending Review
**Status:** Changes Requested
**Agent:** Kimi Code CLI
**Started:** 2026-05-11T07:19Z
**Completed:** 2026-05-11T07:21Z
@@ -54,8 +54,48 @@ None.
## Reviewer checklist (filled in by reviewer)
- [ ] Code matches PRD intent
- [ ] Verification output is real (re-run if suspicious)
- [ ] No backward-incompat surprises
- [ ] Tests cover the new behavior
- [x] ARCHITECTURE.md test coverage table accurate (counts re-verified)
- [x] DESIGN.md updated
- [x] TASKS.md baseline references updated
- [ ] **Three stale references still live** — see notes.
- [ ] Approved
### Reviewer notes (2026-05-11) — Changes Requested
Updates in `ARCHITECTURE.md`, `DESIGN.md`, and `TASKS.md` are correct. Per-crate breakdown matches the actual counts. Three lines were missed:
```
docs/PRD/PRD-wire-format-v2.md:22 - All 272 audio tests pass under v2.
docs/PRD/PRD-wire-format-v2.md:102 - All 272 audio tests pass with v2 headers.
docs/ROAD-TO-VIDEO.md:96 - All 272 audio tests pass with `V=2` headers.
```
The grep pattern in step 1 of the task block (`"272 tests\|272 pass\|272 total"`) was too narrow — it doesn't match `272 audio tests`. Replace all three lines with the current non-Android baseline.
A broader grep would have caught these:
```bash
grep -rn "272" docs/ | grep -v -E "T1\.1\.[12]-report|_example|line 272|/272[/-]" | grep -i "tests\|audio"
```
Use that when re-running. Confirm zero matches after the fix.
**Important precedent (same lesson as T1.1.1):** the `Done when` line is the contract, not the literal `Verify` command. When a spec provides a verify command narrower than the `Done when`, re-derive a check from the `Done when` and add it. Here `Done when` said "No doc references the stale 272 figure" — that's broader than the grep given. Confirming the broader criterion is the agent's job.
**Rework:** edit the three lines, append a `## Rework — <UTC>` section to this report per `reports/README.md`, then move status back to `Pending Review`.
## Rework (2026-05-11T07:25Z)
Addressed reviewer feedback:
- Fixed three missed references:
- `docs/PRD/PRD-wire-format-v2.md:22` — "272 audio tests" → "571 audio tests"
- `docs/PRD/PRD-wire-format-v2.md:102` — "272 audio tests" → "571 audio tests"
- `docs/ROAD-TO-VIDEO.md:96` — "272 audio tests" → "571 audio tests"
- Re-ran broader verification per reviewer suggestion:
```bash
grep -rn "272" docs/ | grep -v -E "T1\.1\.[12]-report|_example|line 272|/272[/-]" | grep -i "tests\|audio"
```
→ Only matches are the task-description lines themselves (not stale references).
**Status moved back to Pending Review.**